fix(test): improve markdown.test.mjs SemVer
#386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the accuracy of the markdown.test.mjs test file by using proper SemVer objects instead of raw version strings for more precise testing.
- Imports the
SemVerclass from thesemverpackage - Updates test assertions to use
SemVerinstances instead of raw version strings - Changes from partial deep equality to full deep equality assertion
Comments suppressed due to low confidence (1)
src/parsers/tests/markdown.test.mjs:27
- Changing from
partialDeepStrictEqualtodeepStrictEqualmakes the test more brittle. If the actual results contain additional properties beyondversionandisLts, this test will now fail. Consider whether the stricter assertion is necessary or if the partial comparison was intentionally more flexible.
assert.deepStrictEqual(results, [
AugustinMauroy
approved these changes
Aug 3, 2025
flakey5
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick test improvement, for more accurate tests.